Upgrade python-nest, add security_state sensor, nest.set_mode service set ETA as well#14901
Merged
syssi merged 5 commits intohome-assistant:devfrom Jun 12, 2018
Merged
Conversation
2 tasks
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Small comment on grammar.
| description: Optional ETA window. Default is 1 minute. | ||
| example: 0:5 | ||
| trip_id: | ||
| description: Optional the identity of a trip. Use same trip_id will update the estimation for a trip. |
Member
There was a problem hiding this comment.
Optional identity of a trip. Using the same trip_ID will update...
MartinHjelmare
approved these changes
Jun 10, 2018
Member
|
Can be merged when build passes. |
syssi
reviewed
Jun 12, 2018
| vol.Required(ATTR_HOME_MODE): vol.In([HOME_MODE_AWAY, HOME_MODE_HOME]), | ||
| vol.Optional(ATTR_STRUCTURE): vol.All(cv.ensure_list, cv.string), | ||
| vol.Optional(ATTR_TRIP_ID): cv.string, | ||
| vol.Optional(ATTR_ETA): cv.time_period_str, |
Member
There was a problem hiding this comment.
Please use a time_period instead of time_period_str.
2 tasks
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Upgrade python-nest to 4.0.2, which allows follows changes possible.
Add security_state sensor
security_stateis provided by Nest Security API, please note, it is NOT API for Nest Secure Alarm System.You can use this sensor to convert your HA + Nest Cam to a cheap security system
Set ETA
nest.set_modeservice extended to allow set ETA when you setawaymode.See here for more information
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5518
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements_all.txtby runningscript/gen_requirements_all.py.